fix: use virtual module for runtime auto-import - #3
Merged
Conversation
The previous approach injected an inline `<script type="module">` with `import "solid-grab"` via transformIndexHtml. Browsers cannot resolve bare module specifiers in inline scripts — Vite only processes scripts that were in the original HTML, not those injected by plugins. Fix: use a virtual module (`virtual:solid-grab-init`) served through Vite's dev server via configureServer middleware. The HTML now gets a `<script type="module" src="/@solid-grab/init">` tag, which the browser fetches as a normal module request. Vite's middleware rewrites the URL to `/@id/virtual:solid-grab-init`, which resolves through the plugin's resolveId/load hooks and gets the bare import properly resolved. Tested and working in ditto-app — overlay activates on Alt+hover. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
import "solid-grab") in inline<script type="module">tags — Vite only processes scripts from the original HTML, not those injected bytransformIndexHtmlvirtual:solid-grab-init) withresolveId/loadhooksconfigureServermiddleware that rewrites/@solid-grab/init→/@id/virtual:solid-grab-initso Vite's dev server resolves the bare import<script type="module" src="/@solid-grab/init">instead of inline codeTest plan
🤖 Generated with Claude Code